Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: date range check #1600

Merged
merged 8 commits into from Feb 9, 2024
Merged

fix: date range check #1600

merged 8 commits into from Feb 9, 2024

Conversation

mShan0
Copy link
Contributor

@mShan0 mShan0 commented Feb 7, 2024

fixes #1599

@arthurschreiber arthurschreiber changed the title test: date range check fix: date range check Feb 7, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (e30d927) 63.77% compared to head (9624741) 78.41%.

Files Patch % Lines
src/data-types/smalldatetime.ts 60.00% 3 Missing and 1 partial ⚠️
src/data-types/date.ts 66.66% 1 Missing ⚠️
src/data-types/datetime.ts 66.66% 1 Missing ⚠️
src/data-types/datetime2.ts 66.66% 1 Missing ⚠️
src/data-types/datetimeoffset.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1600       +/-   ##
===========================================
+ Coverage   63.77%   78.41%   +14.64%     
===========================================
  Files          93       93               
  Lines        4858     4860        +2     
  Branches      932      934        +2     
===========================================
+ Hits         3098     3811      +713     
+ Misses       1356      751      -605     
+ Partials      404      298      -106     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arthurschreiber arthurschreiber merged commit 1c88d76 into master Feb 9, 2024
25 of 30 checks passed
Copy link

github-actions bot commented Feb 9, 2024

🎉 This PR is included in version 16.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mShan0 mShan0 deleted the mark-date-range branch February 9, 2024 17:49
KAMAELUA pushed a commit to KAMAELUA/tedious-decimal that referenced this pull request Apr 29, 2024
* test: date range check

* change datetime range check

* change datetime2 range check

* change datetimeoffset range check

* remove unused constants

* remove todo comments

* smalldatetime range check

* remove unused variables

(cherry picked from commit 1c88d76)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pre 2001 Dates throws Out of Range Error when using params
2 participants