feat: allow specifying the clientId when using azure-active-directory-password auth
#1355
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1355 +/- ##
==========================================
- Coverage 80.86% 79.73% -1.14%
==========================================
Files 88 88
Lines 4662 4672 +10
Branches 860 864 +4
==========================================
- Hits 3770 3725 -45
- Misses 617 679 +62
+ Partials 275 268 -7
Continue to review full report at Codecov.
|
|
Did we want the warning to emit even if the client ID was specified? |
I'm a bit confused. I don't think we want that, and I don't think the current code does that - it only emits the warning if the client id is not specified. Or am I misunderstanding your question? |
|
Ah, now I see! 💡 You're right, we should only emit the warning if the value is |
|
will do! |
mShan0
force-pushed
the
arthur/azure-ad-password-client-id
branch
2 times, most recently
from
1eb7f84
to
b0325da
Compare
| if (options.clientId !== undefined && typeof options.clientId !== 'string') { | ||
| throw new TypeError('The "config.authentication.options.clientId" property must be of type string.'); | ||
| } else { | ||
| emitAzureADPasswordClientIdDeprecationWarning(); |
There was a problem hiding this comment.
We're emitting a deprecation warning if the user did not provide a value for clientId because we want to require the user to pass in a clientId value in the future. 👍
…ory-password` auth Co-authored-by: Michael Sun <v-mutsun@microsoft.com>
mShan0
force-pushed
the
arthur/azure-ad-password-client-id
branch
from
b0325da
to
95e98a1
Compare
|
🎉 This PR is included in version 14.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.