ci: also run integration tests against sql server 2016, 2017 & 2019 on windows #1531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1531 +/- ##
=======================================
Coverage 79.63% 79.63%
=======================================
Files 91 91
Lines 4655 4655
Branches 854 854
=======================================
Hits 3707 3707
Misses 681 681
Partials 267 267 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mShan0
commented
Mar 30, 2023
|
|
||
| sqlcmd -S localhost -q "ALTER LOGIN [sa] WITH PASSWORD=N'yourStrong(!)Password'" | ||
| sqlcmd -S localhost -q "ALTER LOGIN [sa] ENABLE" | ||
| .\setup\setup.exe /q /ACTION=Install /INSTANCENAME=MSSQLSERVER /FEATURES=SQLEngine /UPDATEENABLED=1 /UpdateSource=C:\temp /SQLSVCACCOUNT='NT SERVICE\MSSQLSERVER' /SQLSYSADMINACCOUNTS='BUILTIN\ADMINISTRATORS' /TCPENABLED=1 /NPENABLED=0 /IACCEPTSQLSERVERLICENSETERMS /SQLCOLLATION=SQL_Latin1_General_CP1_CI_AS /SECURITYMODE=SQL /SAPWD="yourStrong(!)Password" |
There was a problem hiding this comment.
Removed /USESQLRECOMMENDEDMEMORYLIMITS because 2016 and 2017 do not support it.
I can add it back in for 2019 and newer if need be
arthurschreiber
changed the title
arthurschreiber
changed the title
arthurschreiber
changed the title
|
🎉 This PR is included in version 16.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AdamJohnSwan
pushed a commit
to AdamJohnSwan/tedious
that referenced
this pull request
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds SQL server versions 2016, 2017, 2019, 2022, and the latest cumulative update for each SQL server version