Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix TDS 8.0 test cases not being executed correctly #1565

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

MichaelSun90
Copy link
Contributor

Our encrypt tests are not running due to SQL version detection that we added. This PR fix that.
When the test actually running, we found out that TDS7_1 does not compatible with SQL server 2022, so we will skip corresponding tests.

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #1565 (155ccf9) into master (b78df14) will increase coverage by 0.87%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1565      +/-   ##
==========================================
+ Coverage   79.83%   80.71%   +0.87%     
==========================================
  Files          92       92              
  Lines        4692     4692              
  Branches      871      871              
==========================================
+ Hits         3746     3787      +41     
+ Misses        673      630      -43     
- Partials      273      275       +2     

see 4 files with indirect coverage changes

@arthurschreiber arthurschreiber changed the title fix: test failures run againest TDS7_1 test: fix TDS 8.0 test cases not being executed correctly Aug 4, 2023
@arthurschreiber arthurschreiber merged commit 2b27531 into master Aug 4, 2023
25 of 26 checks passed
@arthurschreiber arthurschreiber deleted the michael-FixEncryptTest branch August 4, 2023 18:14
@github-actions
Copy link

🎉 This PR is included in version 16.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants