Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imported plan's enabled key is ignored by tmt run #2297

Closed
happz opened this issue Aug 30, 2023 · 1 comment · Fixed by #2343
Closed

Imported plan's enabled key is ignored by tmt run #2297

happz opened this issue Aug 30, 2023 · 1 comment · Fixed by #2343
Assignees
Labels
bug Something isn't working command | plans tmt plans command
Milestone

Comments

@happz
Copy link
Collaborator

happz commented Aug 30, 2023

Import a plan with enabled: false, and tmt run will happily run it. As long as the importing plan itself is enabled, filtering of enabled/disabled plans happen before the import, and it's not repeated.

@happz happz added command | plans tmt plans command bug Something isn't working labels Aug 30, 2023
@lukaszachy
Copy link
Collaborator

lukaszachy commented Aug 30, 2023

Hopefully simpler reproducer, extract into /tmt so /tmp/reproducer directory exists:
in /tmp/reproducer/git1:

tmt plan show tmt -c foo=bar plan show
/plan/no enabled: false enabled: false
/plan/no_in_adjust enabled: true enabled: false
/plan/yes enabled: true enabled: true
/plan/yes_in_adjust enabled: false enabled: true

/tmp/reproducer/git2 contains plans which import the above so they should follow same enabled/disabled depending on context.

Note we have tmt plans --enabled|--disabled filters which should work too.

https://drive.google.com/file/d/1rhiOZukizgC5IntTPIMUs4ZRoPsxQjRz/view?usp=sharing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working command | plans tmt plans command
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants