Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure the imported plan's enabled key is respected #2343

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Ensure the imported plan's enabled key is respected #2343

merged 1 commit into from
Dec 6, 2023

Conversation

therazix
Copy link
Collaborator

Imported plan's enabled key is now respected by tmt. Context and adjust rules are taken into account as well. This should also work for tmt plans show --enabled|--disabled filters.

Fixes #2297

@therazix therazix added the command | plans tmt plans command label Sep 21, 2023
@kkaarreell
Copy link
Collaborator

Hello, I have just hit this issue when importing plan which is being disabled in adjust. I have backported the patch manually and I can confirm it works.
@therazix Could you please rebase this PR? @psss Can we schedule this for the next tmt release please? It seems simple enough to me.

@therazix therazix force-pushed the fvagner-2297-imported-plans-enabled-key branch from 003c064 to da2481f Compare December 1, 2023 11:06
@thrix thrix modified the milestones: 1.31, 1.30 Dec 5, 2023
@therazix therazix force-pushed the fvagner-2297-imported-plans-enabled-key branch 2 times, most recently from df75d18 to c7091f5 Compare December 5, 2023 14:11
@therazix therazix force-pushed the fvagner-2297-imported-plans-enabled-key branch from c7091f5 to 8fa4314 Compare December 6, 2023 10:29
psss
psss requested changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Proposing just a minor enhancement of tests.

tests/plan/import/basic.sh Outdated Show resolved Hide resolved
@psss psss self-assigned this Dec 6, 2023
@psss psss changed the title Ensure the imported plan's enabled key is respected by tmt Ensure the imported plan's enabled key is respected Dec 6, 2023
@psss psss force-pushed the fvagner-2297-imported-plans-enabled-key branch from ededde8 to 0bbd0ec Compare December 6, 2023 13:11
psss
psss approved these changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now looks good, thanks!

@psss psss added the command | import The import command label Dec 6, 2023
@psss
Copy link
Collaborator

psss commented Dec 6, 2023

/packit test --identifier full

@psss psss merged commit 0bbd0ec into main Dec 6, 2023
18 checks passed
@psss psss deleted the fvagner-2297-imported-plans-enabled-key branch December 6, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happz happz happz approved these changes

@psss psss psss approved these changes

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

Assignees

@psss psss

Labels
command | import The import command command | plans tmt plans command
Projects
None yet
Milestone
1.30
Development

Successfully merging this pull request may close these issues.

Imported plan's enabled key is ignored by tmt run
5 participants
@therazix @kkaarreell @psss @happz @thrix