Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add story describing CLI for multiple phases #2286

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Add story describing CLI for multiple phases #2286

merged 2 commits into from
Aug 29, 2023

Conversation

happz
Copy link
Collaborator

@happz happz commented Aug 23, 2023

A follow up for #2188

@happz happz added documentation Improvements or additions to documentation code | cli Changes related to the command line interface labels Aug 23, 2023
@happz happz added this to the 1.27 milestone Aug 23, 2023
@thrix thrix requested a review from janhavlin August 23, 2023 11:15
thrix
thrix requested changes Aug 23, 2023
View reviewed changes
Copy link
Collaborator

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small comments from me

stories/cli/multiple phases.fmf Outdated Show resolved Hide resolved
stories/cli/multiple phases.fmf Outdated Show resolved Hide resolved
@happz happz marked this pull request as ready for review August 28, 2023 13:00
@happz
Copy link
Collaborator Author

happz commented Aug 28, 2023

/packit retest-failed

@thrix thrix self-requested a review August 29, 2023 08:46
thrix
thrix approved these changes Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukaszachy lukaszachy added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Aug 29, 2023
@lukaszachy lukaszachy enabled auto-merge (squash) August 29, 2023 09:30
@happz
Copy link
Collaborator Author

happz commented Aug 29, 2023

/packit retest-failed

@lukaszachy lukaszachy merged commit 41e75a8 into main Aug 29, 2023
15 checks passed
@lukaszachy lukaszachy deleted the story-for-multiphase branch August 29, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrix thrix thrix approved these changes

@lukaszachy lukaszachy lukaszachy approved these changes

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

@psss psss Awaiting requested review from psss psss is a code owner

Assignees
No one assigned
Labels
code | cli Changes related to the command line interface documentation Improvements or additions to documentation status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish.
Projects
None yet
Milestone
1.27
Development

Successfully merging this pull request may close these issues.
3 participants
@happz @thrix @lukaszachy