Extend tmt-reboot to allow reboot from outside of the test process #2311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
I have tested RPMs built from this PR on my test doing a reboot from the outside session and it seems to work well. Great job! |
|
@kkaarreell that's good news, thanks! Adding this PR to 1.28 then, hoping for more testing. |
happz
added
the
command | reboot
happz
force-pushed
the
reboot-from-outside
branch
from
b2559b5
to
88e9676
Compare
|
yep, planning to test also, stay tuned |
happz
force-pushed
the
reboot-from-outside
branch
from
88e9676
to
cc085f6
Compare
happz
force-pushed
the
reboot-from-outside
branch
from
cc085f6
to
4aa02cf
Compare
happz
force-pushed
the
reboot-from-outside
branch
from
4aa02cf
to
b9e9c25
Compare
therazix
reviewed
Oct 3, 2023
happz
force-pushed
the
reboot-from-outside
branch
from
b9e9c25
to
985fdde
Compare
therazix
reviewed
Oct 4, 2023
happz
force-pushed
the
reboot-from-outside
branch
from
985fdde
to
d552e8c
Compare
therazix
approved these changes
Oct 4, 2023
|
Filed #2377 for |
happz
force-pushed
the
reboot-from-outside
branch
from
d552e8c
to
c1010bd
Compare
happz
added
the
status | blocking other work
happz
force-pushed
the
reboot-from-outside
branch
from
c1010bd
to
a2a2c9d
Compare
psss
requested changes
Oct 20, 2023
happz
force-pushed
the
reboot-from-outside
branch
from
a2a2c9d
to
df6ce85
Compare
Patch introduced a "test pidfile" in which the execute plugin would store test process pid. This file is then used by `tmt-reboot` to discover which process to signal when reboot is requested. This allows `tmt-reboot` to be called from outside of the test process tree while keeping tmt in the loop and correctly notified.
psss
force-pushed
the
reboot-from-outside
branch
from
33bae55
to
a6ad1ec
Compare
psss
approved these changes
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch introduced a "test pidfile" in which the execute plugin would
store test process pid. This file is then used by
tmt-reboottodiscover which process to signal when reboot is requested.
This allows
tmt-rebootto be called from outside of the test processtree while keeping tmt in the loop and correctly notified.
Fixes #2067