Make arch field unsupported in the spec
#2552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thrix
requested review from
psss,
lukaszachy,
happz and
janhavlin
as code owners
psss
requested changes
Dec 6, 2023
psss
added
specification
b7b96ca should fix it. |
psss
changed the title
arch field unsupported in the spec.arch field unsupported in the spec
The `arch` field is currently special, and unsupported if it is set in the hardware field. Fix this discrepancy and make sure a warning is show so users are aware to not use it here. Signed-off-by: Miroslav Vadkerti <mvadkert@redhat.com>
psss
force-pushed
the
arch-discrepancy
branch
from
b7b96ca
to
395aa33
Compare
psss
approved these changes
Dec 7, 2023
|
/packit test --identifier full |
|
/packit test |
|
/packit build |
|
/packit test --identifier full |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
archfield is currently special, and unsupported if it is set in the hardware field. Fix this discrepancy and make sure a warning is show so users are aware to not use it here.Pull Request Checklist