Prepare and finish plugins use self.data instead of self.get()
#2579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happz
added
code | style
happz
requested review from
psss,
lukaszachy,
thrix and
janhavlin
as code owners
happz
force-pushed
the
self-data-not-get-prepare-finish
branch
from
6232791
to
8f6f2b7
Compare
KwisatzHaderach
approved these changes
Jan 4, 2024
psss
force-pushed
the
self-data-not-get-prepare-finish
branch
from
8f6f2b7
to
4823f48
Compare
Proper annotations, default values already honored, no need to call a method that cannot be annotated enough.
psss
force-pushed
the
self-data-not-get-prepare-finish
branch
from
4823f48
to
a87cf7a
Compare
|
/packit test --identifier full |
psss
changed the title
self.data instead of self.get()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proper annotations, default values already honored, no need to call a method that cannot be annotated enough.
Pull Request Checklist