-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail dmesg
check if it contains Call Trace
or segfault
#2583
Conversation
@guoguojenna thanks for the patch. I for one like the idea, but I'm afraid that the check would have to be smarter to avoid spoiling all tests. Without taking timestamps into account, one segfault - even a segfault that happened right after the boot, way before tmt connected to the guest for the first time - would mark all following tests as failed. I'm afraid dmesg check would have to approach it in the way AVC check does, i.e. checking |
Actually, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran the test again after this code change, and can fail the dmesg as expected.
00:00:37 fail /rdma/pyverbs-tests-2 (on default-0) [1/2]
00:00:01 pass dmesg (before-test check)
00:00:02 pass avc (after-test check)
00:00:02 fail dmesg (after-test check)
Looks good to me, thank you guoguojenna ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for implementing this. Proposing to extend the test coverage in 35dd22c.
Add test checking that segfault is correctly reported. Co-authored-by: Petr Šplíchal <psplicha@redhat.com>
dmesg
check if it contains Call Trace
or segfault
/packit test |
/packit test -i full |
00:00:33 fail /rdma/pyverbs-tests-2 (on default-0) [1/1]
00:00:00 pass dmesg (before-test check)
00:00:02 pass avc (after-test check)
00:00:01 fail dmesg (after-test check)
When users notice dmesg fail, they can go to check the dmesg output to see if it's a bug.
Fixes #2563.
Pull Request Checklist