Introduce "topology" addresses for guests #2670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happz
added
provision
|
/packit test |
happz
force-pushed
the
guest-primary-and-topology-address
branch
from
13964fe
to
de1349a
Compare
happz
requested review from
KwisatzHaderach,
dav-pascual,
frantisekz,
psss,
lukaszachy,
thrix and
janhavlin
as code owners
|
@happz, do you plan to add some docs? |
Besides a current "guest" attribute - now called "primary address", the patch adds "topology address" for guests to use when talking to each other. As of now, the topology address of a guest is the same as its primary address, but we expected that to change. Related to #2620
happz
force-pushed
the
guest-primary-and-topology-address
branch
from
de1349a
to
fd80346
Compare
janhavlin
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides a current "guest" attribute - now called "primary address", the patch adds "topology address" for guests to use when talking to each other. As of now, the topology address of a guest is the same as its primary address, but we expected that to change.
Related to #2620
Pull Request Checklist