Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifact field #280

Closed
wants to merge 2 commits into from
Closed

Artifact field #280

wants to merge 2 commits into from

Conversation

lukaszachy
Copy link
Collaborator

Document duration as a possible result attribute
Document Artifact as possible test, and later result attribute

Test can produced artifacts as coverage data, junit summaries,
coredumps or other interesting data. By listing them in this attribute
execute steps collects them from the environemnt where test is running and saves
it to the run directory.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this part is now already happenning: The test is executed in it's directory, as defined by path, and after test execution is completed workdir is pulled back from the guest using rsync. Do you propose some additinal processing?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if I store files outside of workdir?
Note that current test aren't supposed to create any content in their workdir.

Maybe we need rethink and, at least for beakerlib tests support rlFileSubmit

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or let executor to "submit" files - beakerlib (and restraint) allow test tu submit file.
I'd like to have those file in 'artifacts' field.

So report plugin knows that something was submitted from the test.
The additional dictionary is to provide meaning to some files - Now I have xunit in mind, but let's make it dynamic.

So say there is junit: file in artifacts and I use report --how junit - plugin knows what files it should check for (parsing any file or arbitratry xml files doesn't seem good idea) and will process them.

spec/steps/execute.fmf Outdated Show resolved Hide resolved
@lukaszachy
Copy link
Collaborator Author

I'll split this into two PRs. Artifact seems to need more discussion.

@lukaszachy
Copy link
Collaborator Author

Not planned as 'test' attribute. Might be part of 'result', depending on solution for issue 2108

@lukaszachy lukaszachy closed this Jun 13, 2023
@lukaszachy lukaszachy deleted the artifact branch June 13, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFE: support specify how to get files back from the environment
2 participants