Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the cpu.vendor hardware requirement #2875

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Add the cpu.vendor hardware requirement #2875

merged 1 commit into from
Apr 23, 2024

Conversation

qcheng-redhat
Copy link
Contributor

@qcheng-redhat qcheng-redhat commented Apr 19, 2024 •
edited by psss
Loading

Pull Request Checklist

  • update the specification
  • modify the json schema

Fix: #2837

@happz happz added specification Metadata specification (core, tests, plans, stories) area | hardware Implementation of hardware requirements labels Apr 19, 2024
@happz happz added this to the 1.33 milestone Apr 19, 2024
psss
psss approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. I just moved the definition a bit in 24211b3 to nicely group family, model and vendor together.

@qcheng-redhat @psss
Add the cpu.vendor hardware requirement
41f4458 
Signed-off-by: qcheng-redhat <qcheng@redhat.com>
@psss psss changed the title Add CPU vendor HW requirement Add the cpu.vendor hardware requirement Apr 23, 2024
@psss psss added the ci | full test Pull request is ready for the full test execution label Apr 23, 2024
@psss
Copy link
Collaborator

psss commented Apr 23, 2024

/packit build

@psss psss merged commit 41f4458 into teemtee:main Apr 23, 2024
18 of 20 checks passed
@psss psss self-assigned this Apr 23, 2024
@qcheng-redhat qcheng-redhat deleted the hw_cpu_vendor branch April 29, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happz happz happz approved these changes

@lukaszachy lukaszachy lukaszachy approved these changes

@psss psss psss approved these changes

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

Assignees

@psss psss

Labels
area | hardware Implementation of hardware requirements ci | full test Pull request is ready for the full test execution specification Metadata specification (core, tests, plans, stories)
Projects
None yet
Milestone
1.33
Development

Successfully merging this pull request may close these issues.

Add CPU vendor HW requirement
4 participants
@qcheng-redhat @psss @happz @lukaszachy