Removing /var/tmp workdir from rpm packaging #2876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinhoyer
requested review from
psss,
lukaszachy,
happz,
thrix and
janhavlin
as code owners
martinhoyer
added
packaging
code | no functional change
happz
approved these changes
Apr 19, 2024
lukaszachy
approved these changes
Apr 19, 2024
|
Just to clarify: So, do we drop the original use case described in #537? |
|
For transparency: As discussed on chat, it is being handled here Line 2064 in 6f82839 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #2803
tmt is creating the workdir by itself and as such does not need to have the directory being packaged as part of the rpm.
This change is in sync with Fedora Python packaging guidelines, harmonizing the rpm package with the PyPI package.
It also fixes the issue of the current implementation not using tmpfiles.d and as such is marked as forbidden by rpmlint Fedora configs.