Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not present discover phase name as a part of test name #2885

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Do not present discover phase name as a part of test name #2885

wants to merge 1 commit into from

Conversation

janhavlin
Copy link
Collaborator

@janhavlin janhavlin commented Apr 24, 2024 •
edited
Loading

Pull Request Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • update the specification
  • adjust plugin docstring
  • modify the json schema
  • mention the version
  • include a release note

Solves #2713.

@janhavlin janhavlin added enhancement step | discover Stuff related to the discover step labels Apr 24, 2024
@janhavlin janhavlin added this to the 1.33 milestone Apr 24, 2024
happz
happz reviewed Apr 24, 2024
View reviewed changes
tmt/base.py Outdated Show resolved Hide resolved
@LecrisUT
Copy link
Contributor

Should document that now the full name with prefix:: is used for regex filter. Also I don't see a mention in the tests about TMT_TEST_NAME. Should make sure that is not affected since it can be used for reusable test scripts.

@janhavlin janhavlin modified the milestones: 1.33, 1.34 Apr 29, 2024
@happz happz modified the milestones: 1.34, 1.35 Jun 11, 2024
@janhavlin janhavlin linked an issue Jun 25, 2024 that may be closed by this pull request
Do not present discover phase name as a part of test name #2713
Open
@janhavlin janhavlin modified the milestones: 1.35, 1.36 Jul 30, 2024
@janhavlin janhavlin modified the milestones: 1.36, 1.37 Aug 27, 2024
@thrix thrix modified the milestones: 1.37, 1.38 Oct 1, 2024
@thrix thrix modified the milestones: 1.38, 1.39 Oct 25, 2024
@thrix thrix modified the milestones: 1.39, 1.40 Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happz happz happz left review comments

@psss psss Awaiting requested review from psss psss will be requested when the pull request is marked ready for review psss is a code owner

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy will be requested when the pull request is marked ready for review lukaszachy is a code owner

@thrix thrix Awaiting requested review from thrix thrix will be requested when the pull request is marked ready for review thrix is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
step | discover Stuff related to the discover step
Projects
None yet
Milestone
1.40
Development

Successfully merging this pull request may close these issues.

Do not present discover phase name as a part of test name
5 participants
@janhavlin @LecrisUT @happz @thrix @psss