Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support disk.sector-size hardware requirement for mrack #2973

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Support disk.sector-size hardware requirement for mrack #2973

merged 1 commit into from
Jul 30, 2024

Conversation

skycastlelily
Copy link
Collaborator

@skycastlelily skycastlelily commented May 31, 2024 •
edited
Loading

Pull Request Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • update the specification
  • adjust plugin docstring
  • modify the json schema
  • mention the version
  • include a release note

@skycastlelily skycastlelily added the ci | full test Pull request is ready for the full test execution label May 31, 2024
@happz happz added step | provision Stuff related to the provision step area | hardware Implementation of hardware requirements plugin | mrack The beaker provision plugin labels Jun 5, 2024
@skycastlelily
Copy link
Collaborator Author

Updated^^

@happz happz added this to the 1.35 milestone Jul 2, 2024
@skycastlelily
Copy link
Collaborator Author

Rebased,and updated, this one is ready to be merged^^

@happz happz added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Jul 30, 2024
@happz
Copy link
Collaborator

happz commented Jul 30, 2024

Unrelated failures, merging.

@happz happz merged commit 924e5b5 into main Jul 30, 2024
19 of 20 checks passed
@happz happz deleted the sector-size-mrack branch July 30, 2024 17:15
The-Mule pushed a commit to The-Mule/tmt that referenced this pull request Oct 14, 2024
@skycastlelily @The-Mule
Support disk.sector-size hardware requirement for mrack (teemtee#2973)
9421b54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happz happz happz approved these changes

@janhavlin janhavlin janhavlin approved these changes

@therazix therazix therazix approved these changes

@dav-pascual dav-pascual Awaiting requested review from dav-pascual dav-pascual is a code owner

@psss psss Awaiting requested review from psss psss is a code owner

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

Assignees
No one assigned
Labels
area | hardware Implementation of hardware requirements ci | full test Pull request is ready for the full test execution plugin | mrack The beaker provision plugin status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. step | provision Stuff related to the provision step
Projects
None yet
Milestone
1.35
Development

Successfully merging this pull request may close these issues.
4 participants
@skycastlelily @happz @janhavlin @therazix