Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docstrings of regex template filters #3011

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Fix docstrings of regex template filters #3011

merged 2 commits into from
Aug 19, 2024

Conversation

happz
Copy link
Collaborator

@happz happz commented Jun 12, 2024

They we a bit messy, especially examples.

Pull Request Checklist

  • implement the feature

@happz happz added documentation Improvements or additions to documentation code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. labels Jun 12, 2024
@happz happz mentioned this pull request Jun 12, 2024
Merged
1 task
@happz happz added the ci | full test Pull request is ready for the full test execution label Jun 12, 2024
@happz happz added this to the 1.35 milestone Jul 2, 2024
@happz happz force-pushed the split-utils-2-extract-templates branch from 20a1ac8 to 4b3c754 Compare July 6, 2024 16:42
@happz happz requested a review from martinhoyer as a code owner July 6, 2024 16:42
@happz happz force-pushed the split-utils-2-extract-templates branch 2 times, most recently from fa2f667 to cfbdbec Compare July 24, 2024 07:26
@happz happz force-pushed the split-utils-2-extract-templates branch from cfbdbec to 8ebce1d Compare July 29, 2024 08:31
martinhoyer
martinhoyer approved these changes Aug 1, 2024
View reviewed changes
tests/integration/__init__.py Show resolved Hide resolved
@happz happz modified the milestones: 1.35, 1.36 Aug 2, 2024
@happz happz added the status | blocked The merging of PR is blocked on some other issue label Aug 2, 2024
@happz
Copy link
Collaborator Author

happz commented Aug 2, 2024

Added blocked label: depends on a branch that's been pushed out to 1.36, the rebase would be a mess, and it's not critical.

@happz happz force-pushed the split-utils-2-extract-templates branch 2 times, most recently from 7fccaa9 to f77a76a Compare August 13, 2024 15:10
@happz happz force-pushed the split-utils-2-extract-templates branch from f77a76a to 1d5d68c Compare August 14, 2024 11:49
Base automatically changed from split-utils-2-extract-templates to main August 14, 2024 13:58
@happz happz force-pushed the split-utils-6-fix-template-docstrings branch from 43c0145 to 545cc20 Compare August 14, 2024 14:40
@happz happz added status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. and removed status | blocked The merging of PR is blocked on some other issue labels Aug 15, 2024
@happz happz force-pushed the split-utils-6-fix-template-docstrings branch from 2359047 to 3de54d2 Compare August 15, 2024 12:15
@happz
Copy link
Collaborator Author

happz commented Aug 19, 2024

/packit build

@happz happz merged commit c5c214a into main Aug 19, 2024
20 checks passed
@happz happz deleted the split-utils-6-fix-template-docstrings branch August 19, 2024 13:07
The-Mule pushed a commit to The-Mule/tmt that referenced this pull request Oct 14, 2024
@happz @The-Mule
Fix docstrings of regex template filters (teemtee#3011)
05f38c5 
They were a bit messy, especially examples.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KwisatzHaderach KwisatzHaderach KwisatzHaderach approved these changes

@martinhoyer martinhoyer martinhoyer approved these changes

@therazix therazix therazix approved these changes

@psss psss Awaiting requested review from psss psss is a code owner

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

Assignees
No one assigned
Labels
ci | full test Pull request is ready for the full test execution code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. documentation Improvements or additions to documentation status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish.
Projects
None yet
Milestone
1.36
Development

Successfully merging this pull request may close these issues.
4 participants
@happz @KwisatzHaderach @martinhoyer @therazix