Require --feeling-safe for local provisioning

[martinhoyer]

Resolves #3027

Pull Request Checklist

• implement the feature
• write the documentation
• extend the test coverage
• update the specification
• adjust plugin docstring
• modify the json schema
• mention the version
• include a release note

[martinhoyer]

@happz Could you please give me a sanity check here?
I was thinking about creating some reusable decorator for this, but got a bit lost with the loggers, etc and wasn't sure how to make it universal.
If you could give me some pointers how would you like me to do this, it would be much appreciated.

[happz]

@happz Could you please give me a sanity check here? I was thinking about creating some reusable decorator for this, but got a bit lost with the loggers, etc and wasn't sure how to make it universal. If you could give me some pointers how would you like me to do this, it would be much appreciated.

Sure. I didn't think about using a decorator, seems like too much work, and then one can decorate functions and methods only, which means we would need to refactor code to be able to decorate with the "feeling safe" decorator.

What you have seems fine to me in general, just a few comments WRT implementation:

• instead of an explicit check of environment, we could add envvar to the option in tmt/options.py. That should work out of the box, Click would then extract the value from the environment for us.

• that would also align TMT_FEELING_SAFE with flag-like envvars for plugin options, see the note in https://tmt.readthedocs.io/en/stable/overview.html#plugin-variables - i.e. not TMT_FEELING_SAFE=true but TMT_FEELING_SAFE=1.

• the check looks like we should have a helper function for it, to isolate local.py from the burden of __version__ and so on. Something we could re-use easily, something like assert_feeling_safe("1.38", "The 'local' provision plugin"), to check the option, the tmt version, emit the message, maybe return True if everything was fine so the caller could continue or quit. Something we can cover with a unit test, e.g.:

  def assert_feeling_safe(version: str, subject: str) -> bool:
      if self.is_feeling_safe:
          return True
  
      if tmt.__version__ < version:
          self.warn(f"{subject} will require '--feeling-safe' option from version {version}.")
          return True
  
      self.fail(f"{subject} requires '--feeling-safe' option")
      return False

[martinhoyer]

Thanks a lot @happz, that was super helpful feedback. I've tried to incorporate your suggestions, but haven't had time to test it properly. Also, the unit test is kinda work in progress - I need to go through existing tests to see how things are done here.

[happz]

Unrelated failures, merging.