Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use checkmark and cross for hardware support matrix #3122

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Use checkmark and cross for hardware support matrix #3122

merged 1 commit into from
Jul 30, 2024

Conversation

LecrisUT
Copy link
Contributor

@LecrisUT LecrisUT commented Jul 30, 2024 •
edited
Loading

The color scheme is rather confusing as it clashes with the hyperlink text right next to it (from #3121)

Screenshot_20240730_133159

Proposing to use emojis instead ✅❌

@happz do you want to cherry-pick this one into #3121? There is not much value to it as standalone

Pull Request Checklist

  • implement the feature

@happz
Copy link
Collaborator

happz commented Jul 30, 2024

@LecrisUT thanks for the patch, but I'd rather not cherry-pick it. This PR is a result of git bisect, I'd like to keep history cleaner for future engineers & their bisect fun :)

@happz happz added documentation Improvements or additions to documentation code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. labels Jul 30, 2024
@happz happz added this to the 1.35 milestone Jul 30, 2024
thrix
thrix approved these changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@happz happz added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Jul 30, 2024
martinhoyer
martinhoyer approved these changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@martinhoyer martinhoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. It would be cool to also have them in the center of the cells, but that's maybe for other PR...

@happz
Copy link
Collaborator

happz commented Jul 30, 2024

Documentation-only, merging.

@happz happz merged commit 615b4a1 into teemtee:main Jul 30, 2024
11 checks passed
@LecrisUT LecrisUT deleted the patch-1 branch July 30, 2024 21:20
The-Mule pushed a commit to The-Mule/tmt that referenced this pull request Oct 14, 2024
@LecrisUT @The-Mule
Use checkmark and cross for support matrix (teemtee#3122)
1ef8016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrix thrix thrix approved these changes

@martinhoyer martinhoyer martinhoyer approved these changes

@therazix therazix therazix approved these changes

@psss psss Awaiting requested review from psss psss is a code owner

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@happz happz Awaiting requested review from happz happz is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

Assignees
No one assigned
Labels
code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. documentation Improvements or additions to documentation status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish.
Projects
None yet
Milestone
1.35
Development

Successfully merging this pull request may close these issues.
5 participants
@LecrisUT @happz @thrix @martinhoyer @therazix