Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of empty set of allowed linters #3158

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

happz
Copy link
Collaborator

@happz happz commented Aug 20, 2024

Empty set is not the same as unset, and the test must respect that.

Fixes #3156

Pull Request Checklist

  • implement the feature

@happz happz added bug Something isn't working command | lint tmt lint command labels Aug 20, 2024
@happz happz added this to the 1.36 milestone Aug 20, 2024
@happz happz added status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. ci | full test Pull request is ready for the full test execution labels Aug 22, 2024
Empty set is not the same as unset, and the test must respect that.

Fixes #3156
@happz happz force-pushed the lint-G001-cannot-be-disabled branch from adea61e to 9c749c1 Compare August 27, 2024 09:29
@happz
Copy link
Collaborator Author

happz commented Aug 27, 2024

Unrelated failures, merging.

@happz happz merged commit 2faebfd into main Aug 27, 2024
20 of 22 checks passed
@happz happz deleted the lint-G001-cannot-be-disabled branch August 27, 2024 11:29
The-Mule pushed a commit to The-Mule/tmt that referenced this pull request Oct 14, 2024
Empty set is not the same as unset, and the test must respect that.

Fixes teemtee#3156
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci | full test Pull request is ready for the full test execution command | lint tmt lint command status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tmt: can't disable lint check G001
3 participants