Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop no longer needed apt update from package manager tests #3189

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Drop no longer needed apt update from package manager tests #3189

merged 1 commit into from
Sep 6, 2024

Conversation

happz
Copy link
Collaborator

@happz happz commented Sep 5, 2024

It's been baked into test container image for some time.

Pull Request Checklist

  • implement the feature

@happz happz added code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. test coverage Improvements or additions to test coverage of tmt itself code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. labels Sep 5, 2024
@happz happz added this to the 1.37 milestone Sep 5, 2024
thrix
thrix approved these changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@happz happz added status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. ci | full test Pull request is ready for the full test execution labels Sep 6, 2024
@happz
Drop no longer needed apt update from package manager tests
9c89841 
It's been baked into test container image for some time.
@happz happz force-pushed the test-apt-container-extra-update branch from c4b85b7 to 9c89841 Compare September 6, 2024 12:18
@happz happz merged commit 7b16db6 into main Sep 6, 2024
22 checks passed
@happz happz deleted the test-apt-container-extra-update branch September 6, 2024 14:26
The-Mule pushed a commit to The-Mule/tmt that referenced this pull request Oct 14, 2024
@happz @The-Mule
Drop no longer needed apt update from package manager tests (teemte…
86b6f28 
…e#3189)

It's been baked into test container image for some time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therazix therazix therazix approved these changes

@thrix thrix thrix approved these changes

@psss psss Awaiting requested review from psss psss is a code owner

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

Assignees
No one assigned
Labels
ci | full test Pull request is ready for the full test execution code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. test coverage Improvements or additions to test coverage of tmt itself
Projects
None yet
Milestone
1.37
Development

Successfully merging this pull request may close these issues.
3 participants
@happz @thrix @therazix