Remove successful runs unless explicitely blocked #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: František Nečas <fnecas@redhat.com>
FrNecas
force-pushed
the
frnecas-remove-successful
branch
from
793798d
to
f8ea4b8
Compare
|
As discussed today on the hacking session, this change is modifying behaviour and would need adjustments in the pipelines. The best approach seems to be to allow this to be enabled in user configuration. Thus proposing for 2.0. |
|
An alternative approach which could nicely work with the Testing Farm without breakage proposed in #1707. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably the most non-invasive way of reducing space used by tmt - from my experience it is very rare to want to do something with a run where
finishstep ran and all tests were successful. However, it may slightly break some use-cases (--keepmay be needed) which turned out to be the case in some of our tests (however I feel like those scenarios wouldn't be common when using tmt on a daily basis). What do you think about this change @psss @thrix @lukaszachy ? Does this sound reasonable to you?Resolves: #645