Add script to check and report ENV usage #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
a list from when we talked offline:
|
jennielouie
force-pushed
the
jl/envm_lint
branch
3 times, most recently
from
f425479
to
c3c6942
Compare
|
@chrisledet added the options, can you re-review? |
| usage = <<USAGE | ||
| Usage: #{$PROGRAM_NAME} <options> | ||
|
|
||
| Recursively checks for usage of "ENV[" in all .rb and .erb files of a directory, and prints usage summary. |
There was a problem hiding this comment.
What if we removed the [ from "+Recursively checks for usage of "ENV[" ?
jennielouie
force-pushed
the
jl/envm_lint
branch
2 times, most recently
from
7766b7a
to
c313407
Compare
| begin | ||
| if ARGV.include?('--help') | ||
| puts usage | ||
| exit |
There was a problem hiding this comment.
The spacing is off inside the if/end
|
👍 |
jennielouie
force-pushed
the
jl/envm_lint
branch
from
c313407
to
77a52ca
Compare
jennielouie
added a commit
that referenced
this pull request
Jan 14, 2016
Add script to check and report ENV usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Script recursively checks files in project directory for " ENV[ ", and reports filepaths and # occurrences where it is found.