Fix use="required" for attributes in inner classes. #820

skinkie · 2023-07-14T00:45:16Z

📒 Description

When an element has a restriction, it may override an attribute's use-attribute, for example from optional to required. This patch reflects this change.

Resolves #819

🔗 What I've Done

Write a description of the steps taken to resolve the issue

#819 contains the minimum XSD to check the generation. I basically step by step went though the generation process until I found that RESOLVE causes the attributes of 'test' to disappear.

💬 Comments

First true contribution? ;-)

🛫 Checklist

Updated docs
Added unit-tests
Sample tests pass
W3C tests pass

codecov · 2023-07-14T00:47:57Z

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (fcb89c2) 99.96% compared to head (8f7e789) 99.96%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #820   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files         104      104           
  Lines        9249     9263   +14     
  Branches     2068     2073    +5     
=======================================
+ Hits         9246     9260   +14     
  Partials        3        3

Impacted Files	Coverage Δ
...data/codegen/handlers/calculate_attribute_paths.py	`100.00% <ø> (ø)`
.../codegen/handlers/validate_attributes_overrides.py	`100.00% <ø> (ø)`
xsdata/codegen/handlers/create_compound_fields.py	`100.00% <100.00%> (ø)`

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Fix tefra#819

tefra · 2023-07-16T09:56:11Z

Good first attempt, unfortunately lately a lot of issues have the butterfly effect. Hacks or questionable decisions appear out of nowhere in unrelated areas.