Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use definition elements location for generated classes #832

Merged
merged 1 commit into from
Jul 23, 2023
Merged

Conversation

tefra
Copy link
Owner

@tefra tefra commented Jul 21, 2023

📒 Description

The wsdl parser/mapper assume that all the wsdl definitions elements are located in the safe file.
This is causing all the service classes to be grouped to the same file.

Resolves #823

🔗 What I've Done

Set the location for each binding operation, port type, services, messages etc etc...
In the definitions mapper for each service class use the location property of each respective element.

💬 Comments

A place to write any comments to the reviewer.

🛫 Checklist

@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ed6927a) 99.96% compared to head (996ca43) 99.96%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #832   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files         104      104           
  Lines        9262     9270    +8     
  Branches     2072     2072           
=======================================
+ Hits         9259     9267    +8     
  Partials        3        3           
Impacted Files Coverage Δ
xsdata/codegen/mappers/definitions.py 100.00% <100.00%> (ø)
xsdata/codegen/parsers/definitions.py 100.00% <100.00%> (ø)
xsdata/models/wsdl.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tefra tefra merged commit 7372769 into main Jul 23, 2023
19 checks passed
@tefra tefra deleted the fix-823 branch July 23, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple WSDL files on the generator path will conflate the WSDL definitions in a single file
1 participant