Improve walking #42
Improve walking #42
Conversation
Gary-BOT
force-pushed
the
feature/pokestop_improvements
branch
2 times, most recently
from
9745a9b
to
c77feb6
Compare
|
Possibly unrelated to the PR, but while catching worked fine my bot account was softbanned as soon as it went to a pokestop (or, at least, reported being softbanned) EDIT: doesn't seem the account was soft-banned due to catching pokemon on another run, so I think this PR causes the soft-ban message to show unnecessarily. EDIT2: Tried PR again, worked at one pokestop then soft-ban warning |
Gary-BOT
force-pushed
the
feature/pokestop_improvements
branch
2 times, most recently
from
a89f404
to
211786e
Compare
|
@MaxLeiter I had that issue too until I noticed that @Gary-BOT is merging from a branch on this repo, not their own. Double check that. Anyways, I tested this with Gary for a good 30 minutes or so working out some interesting edge cases. LGTM |
|
Just adding some information from slack. Seems like a movement speed of 30 == softban. |
|
👍 from me, nice work 💯 |
| def work_on_cell(self, map_cells, position, include_fort_on_path): | ||
| self._remove_ignored_pokemon(map_cells) | ||
|
|
||
| if (self.config.mode == "all" or self.config.mode == "poke"): |
There was a problem hiding this comment.
could we make this and the lines below on if statement? Or is there a reason to not do so?
|
👍 seems ready to merge |
|
Branch needs to be updated / rebased 👎 |
Gary-BOT
force-pushed
the
feature/pokestop_improvements
branch
from
211786e
to
6ae10b3
Compare
|
👍 |
|
👍 |
|
👍 |
|
🎉 |
Short Description:
Walking would travel to the ends of the earths in some cases, this was unnecessary.
Changes:
@OpenPoGo/maintainers