Added: dynamic images (JPG/PNG) generator with SSRF token #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @teknogeek 馃憢
Motivation
While playing with your utility I noticed that when I send a request to routes:
GET/abc.jpgGET/abc.gifThe server is returning an image with
size (1x1). And I think it will cool to add as a minimum full-size image in response.Because in some type of Content-Based SSRF (like in Screenshot / PDF generators ) it is difficult for the attacker to check whether he was able to get an image from the internal infrastructure. If the image only takes 1x1 pixel. In this case, it is easy not to notice that the vulnerability has been successfully exploited.
Changes
In this pull-request I have added: