Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre public setup #21

Merged
merged 7 commits into from
Jul 10, 2022
Merged

Conversation

aldy505
Copy link
Member

@aldy505 aldy505 commented Jul 10, 2022

Closes #10

@aldy505 aldy505 added the enhancement New feature or request label Jul 10, 2022
@aldy505 aldy505 requested review from elianiva and RayWP July 10, 2022 09:32
@aldy505 aldy505 self-assigned this Jul 10, 2022
Comment on lines +240 to +242
stdout: stdout.slice(0, 5000),
stderr: stderr.slice(0, 5000),
output: output.slice(0, 5000),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mau limit 5MB atau 5k characters? kalo 5MB harus pake Buffer.byteLength biar bener ngitungnya kalo ada multibyte character

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5k characters

@aldy505 aldy505 merged commit 184b245 into feat/db-env-vars-registration Jul 10, 2022
@aldy505 aldy505 deleted the chore/pre-public-setup branch July 10, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants