Add Jib Gradle catalog / fix Docker config issue for Jib Maven

[chanseokoh]

Changes

Add Jib Gradle catalog / fix Docker config issue for Jib Maven

• Add Jib Gradle catalog: counterpart of Jib Maven.
• Change the user home inside JVM from /builder/home to /tekton/home in Jib Maven
  • See: Phase out overwriting of image's HOME variable. Remove /tekton/home. pipeline#2013 (comment)
• Run Jib Maven in batch mode (mvn -B ...)

(@GoogleContainerTools/java-tools-build FYI)

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes docs (if user facing)
• Commit messages follow commit message best practices
• Yaml file complies with yamllint rules.

See the contribution guide
for more details.

[tekton-robot]

Hi @chanseokoh. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[chmouel]

/ok-to-test

[chmouel]

I think it would be good to think about consolidating all related commands to jib/ ie jib/maven.yaml jib/gradle.yaml but that may be done next as a scleanup

[chanseokoh]

Any chance to get this reviewed?

[chmouel]

I don't think we should use /tekton/home directly in case if that change and with the work @sbwsg is planning to do, what do you think Scott?

[ghost]

Yeah, unless I'm misunderstanding the purpose I think the safest thing will be to use $HOME. It should be /tekton/home until we flip the default behaviour to be whatever the image expects to be HOME and then it should follow that as well.

[chanseokoh]

@sbwsg @chmouel I don't think I can use $HOME in the following locations. Knowing that, I'd rather use the /tekton/home literal, since at least things won't break even if $HOME changes under the hood. It will continue to work; it will be just that everyone will assume /tekton/home is a user home and use it.

    - name: $(inputs.params.CACHE)
      mountPath: /tekton/home/.gradle/caches
      subPath: gradle-caches
    - name: $(inputs.params.CACHE)
      mountPath: /tekton/home/.gradle/wrapper
      subPath: gradle-wrapper
    - name: $(inputs.params.CACHE)
      mountPath: /tekton/home/.m2
      subPath: m2-cache
    - name: $(inputs.params.CACHE)
      mountPath: /tekton/home/.cache
      subPath: jib-cache

[ghost]

Could this be an opportunity to use workspaces instead of raw volumes? You wouldn't need to pass a string volume name around as a param, users of your task would have the opportunity to pass PVCs or empty dirs as they see fit, and they could specify subPaths of those volumes if they wanted to share the caches on a single volume as is done here.

/tekton is generally intended as a reserved area for Tekton internals. Having it include a home directory seems, in hindsight, to be a mistake. I totally understand if you need a literal directory name to use but I don't recommend anything under /tekton.

[chanseokoh]

Unfortunately, the user home must be /tekton/home in JVM, because Tekton auth creates a Docker config at /tekton/home/.docker/config.json. Unless Tekton fixes this or has an option to create that file on <actual home by image>/.docker/config.json, I have no choice but force /tekton/home as the home directory. Otherwise, Jib just cannot find this file.

(And if you haven't realized, when the user home is set to /tekton/home in JVM, Gradle and Maven write artifacts to /tekton/home/.m2, etc.)

Yeah, this is very unfortunate and has been pretty annoying as I said in tektoncd/pipeline#2013 (comment) I hope Tekton fixes the home issue quickly.

[ghost]

Oh dear. OK then. 👍

[chmouel]

Fine by me, just need to make sure about /tekton/home if there is a better way to do this,

[vdemeester]

/lgtm

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbwsg,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment