Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out how to store attestations on OCI images #203

Closed
Tracked by #205
dlorenc opened this issue Aug 21, 2021 · 2 comments · Fixed by #208
Closed
Tracked by #205

Figure out how to store attestations on OCI images #203

dlorenc opened this issue Aug 21, 2021 · 2 comments · Fixed by #208
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@dlorenc
Copy link
Contributor

dlorenc commented Aug 21, 2021

We've started storing attestations for images in cosign using a ".att" suffix. We should figure out how to do that here in chains (right now we don't support storing attestations in OCI). I think the biggest challenge will be that the storage backends don't know what they're storing (signatures vs. attestations), and we hardcoded the ".sig" suffix.

cc @priyawadhwa any ideas?

@dlorenc dlorenc added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 21, 2021
@priyawadhwa priyawadhwa mentioned this issue Aug 23, 2021
10 tasks
@priyawadhwa
Copy link
Contributor

I think we can check if the payload we're uploading is an OCI image or an in-toto statement, and if it's the image then create the signature the way we've been doing it with cosign

cosignDst := cosign.AttachedImageTag(ref.Repository, dgst, cosign.SignatureTagSuffix)

and if it's the in-toto statement we can use the cosign library for generating the attestation layer & used the cosign.AttestationTagSuffix suffix and upload that

is there anything i'm missing?

@dlorenc
Copy link
Contributor Author

dlorenc commented Aug 24, 2021

nope, sgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants