Add new v2alpha4 version for TaskRuns #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
do-not-merge/work-in-progress
|
Hi @renzodavid9. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tekton-robot
added
needs-ok-to-test
renzodavid9
force-pushed
the
1065-stepactions-taskrun-attestation
branch
2 times, most recently
from
d4c6dd2
to
aaab6d7
Compare
tekton-robot
removed
the
do-not-merge/work-in-progress
|
/ok-to-test |
tekton-robot
added
ok-to-test
renzodavid9
force-pushed
the
1065-stepactions-taskrun-attestation
branch
from
aaab6d7
to
ad42c97
Compare
|
The following is the coverage report on the affected files.
|
|
/retest |
1 similar comment
|
/retest |
renzodavid9
force-pushed
the
1065-stepactions-taskrun-attestation
branch
from
ad42c97
to
67726fe
Compare
renzodavid9
force-pushed
the
1065-stepactions-taskrun-attestation
branch
from
67726fe
to
c4f3e41
Compare
|
The following is the coverage report on the affected files.
|
renzodavid9
force-pushed
the
1065-stepactions-taskrun-attestation
branch
from
c4f3e41
to
cc88a97
Compare
|
The following is the coverage report on the affected files.
|
renzodavid9
force-pushed
the
1065-stepactions-taskrun-attestation
branch
from
cc88a97
to
602ffcf
Compare
|
The following is the coverage report on the affected files.
|
|
/retest |
|
The following is the coverage report on the affected files.
|
renzodavid9
force-pushed
the
1065-stepactions-taskrun-attestation
branch
from
35a0998
to
a1633e3
Compare
|
The following is the coverage report on the affected files.
|
renzodavid9
force-pushed
the
1065-stepactions-taskrun-attestation
branch
2 times, most recently
from
2200ea4
to
ce90cb6
Compare
|
The following is the coverage report on the affected files.
|
renzodavid9
force-pushed
the
1065-stepactions-taskrun-attestation
branch
from
ce90cb6
to
7f0127e
Compare
|
The following is the coverage report on the affected files.
|
renzodavid9
force-pushed
the
1065-stepactions-taskrun-attestation
branch
2 times, most recently
from
e391065
to
fe57763
Compare
|
The following is the coverage report on the affected files.
|
renzodavid9
force-pushed
the
1065-stepactions-taskrun-attestation
branch
from
fe57763
to
9339b2c
Compare
|
The following is the coverage report on the affected files.
|
renzodavid9
force-pushed
the
1065-stepactions-taskrun-attestation
branch
from
9339b2c
to
46d1109
Compare
|
The following is the coverage report on the affected files.
|
tekton-robot
added
the
needs-rebase
This new version will now process the information from any associated StepAction from the executed TaskRun. Also, the way chains read results from TaskRun to populate the `subjects` field is changing: now the user has to explicitly mark a result as a subject using an bject type-hinted tag (*ARTIFACT_OUTPUTS) + the new `isBuildArtifact` property in the value
renzodavid9
force-pushed
the
1065-stepactions-taskrun-attestation
branch
from
46d1109
to
89cd6c6
Compare
tekton-robot
removed
the
needs-rebase
|
The following is the coverage report on the affected files.
|
renzodavid9
force-pushed
the
1065-stepactions-taskrun-attestation
branch
from
89cd6c6
to
1611c11
Compare
|
The following is the coverage report on the affected files.
|
chitrangpatel
approved these changes
May 21, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chitrangpatel, lcarva The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks for the linter fixes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related with: #1065
This new version will now process the information from any associated StepAction from the executed TaskRun.
Also, the way chains read results from TaskRun to populate the
subjectsfield is changing: now the user has to explicitly mark a result as a subject using an bject type-hinted tag (*ARTIFACT_OUTPUTS) + the newisBuildArtifactproperty in the valueNOTE: Updating the Tekton version used in e2e tests to enable StepActions is breaking the Rekor behavior. A tracking issue was opened in #1117. After we solve that issue we would be able to add back the integration test with StepActions. We evaluated to do the test using the GitHub actions but we don't have an easy way to target an specific e2e test to not run in all the matrix of Pipeline releases. Also looks like GitHub tests are only testing one case.
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes