Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tutorial for generating signed provenance #238

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

priyawadhwa
Copy link
Contributor

This should help people set up signing OCI images and generating signed provenance for them.

closes #236

This should help people set up signing OCI images and generating signed provenance for them.
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 22, 2021
Copy link

@lukehinds lukehinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awseome, and very useful! I think your editor might not have incremented its numbering, so I tiny nit

## Set up Authentication
There are two forms of authentication that need to be set up:
1. The default service account in the default namespace needs permission to push to your registry, since this is what Chains will be using for pushing signatures. See our [authentication doc](../authentication.md)
1. The Kaniko Task that will build and push the image needs push permissions for your registry

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be 2. ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markdown will render this fine!

@dlorenc
Copy link
Contributor

dlorenc commented Sep 23, 2021

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2021
@dlorenc
Copy link
Contributor

dlorenc commented Sep 23, 2021

/approve

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlorenc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2021
@tekton-robot tekton-robot merged commit 9bd7fb8 into tektoncd:main Sep 23, 2021
@priyawadhwa priyawadhwa deleted the provenance-tutorials branch September 27, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tutorial for setting up Chains with signed provenance
4 participants