Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaned up golangci-lint and added additional linters. #661

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Cleaned up golangci-lint and added additional linters. #661

merged 1 commit into from
Jan 4, 2023

Conversation

bendory
Copy link
Contributor

@bendory bendory commented Dec 28, 2022 •
edited
Loading

Changes

Cleaned up golangci-lint and added additional linters.

  • Cleaned up configuration, which previously violated whitespace conventions for yaml
  • Added link to documentation
  • Enabled additional linters

There are no expected functional changes in this PR.

Larger context: tektoncd/pipeline#5899 -- we should also be upleveling our conformance with Go style here in Chains!

/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [N/A] Has Docs included if any changes are user facing
  • [N/A] Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • [N/A] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • [N/A] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 28, 2022
@bendory
Copy link
Contributor Author

bendory commented Dec 28, 2022

/retest

2 similar comments
@bendory
Copy link
Contributor Author

bendory commented Dec 29, 2022

/retest

@bendory
Copy link
Contributor Author

bendory commented Dec 29, 2022

/retest

@bendory
Copy link
Contributor Author

bendory commented Dec 29, 2022

/retest

flakes are horrid here -- every run results in a different failure!

@bendory
Cleanup golangci-lint and added additional linters.
f7a3182 
- Cleaned up configuration
- Added link to documentation
- Enabled additional linters

There are no expected functional changes in this PR.

/kind cleanup
wlynch
wlynch approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@wlynch wlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 4, 2023
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2023
@tekton-robot tekton-robot merged commit 8bbbe55 into tektoncd:main Jan 4, 2023
@bendory bendory deleted the c1 branch January 4, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlynch wlynch wlynch approved these changes

@chuangw6 chuangw6 Awaiting requested review from chuangw6

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

Assignees

@wlynch wlynch

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bendory @tekton-robot @wlynch