Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build deterministic/reproducible bundles by default #2135

Closed
zregvart opened this issue Sep 27, 2023 · 0 comments · Fixed by #2139
Closed

Build deterministic/reproducible bundles by default #2135

zregvart opened this issue Sep 27, 2023 · 0 comments · Fixed by #2139
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@zregvart
Copy link
Contributor

Feature request

With #2132 the tkn bundle push command will create a deterministic/reproducible OCI image if --ctime parameter is provided and set to the same value.

A comment on the pull request implementing that suggested that building deterministic/reproducible OCI image should be the default.

Given that the default created time could be set to a fixed value by default, say 1970-01-01T00:00:00Z.

Use case

It helps to be a bit more correct by default

UI Example

Instead of tkn bundle push --ctime '1970-01-01T00:00:00Z' -f... one could use tkn bundle push -f....

@zregvart zregvart added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 27, 2023
zregvart added a commit to zregvart/tkn-cli that referenced this issue Oct 9, 2023
Sets the default created time to 1970-01-01T00:00:00Z (Unix epoch)
instead of the current time.

Fixes tektoncd#2135
zregvart added a commit to zregvart/tkn-cli that referenced this issue Oct 9, 2023
Sets the default created time to 1970-01-01T00:00:00Z (Unix epoch)
instead of the current time.

Fixes tektoncd#2135
tekton-robot pushed a commit that referenced this issue Oct 12, 2023
Sets the default created time to 1970-01-01T00:00:00Z (Unix epoch)
instead of the current time.

Fixes #2135
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant