Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PipelineResource support in task #1984

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

pratap0007
Copy link
Contributor

@pratap0007 pratap0007 commented Apr 12, 2023

As Pipelineresources have been removed in 0.46 pipeline so this patch removes removes inputresources and outputresources flag in tkn task start command and updates unit test

Closes part of: #1657

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

Release Notes

 This will removes removes inputresources and outputresources flag in tkn task start command and updates unit test

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 12, 2023
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 12, 2023
@piyush-garg
Copy link
Contributor

/retest

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vinamra28

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2023
@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2023
As Pipelineresources have been removed in 0.46 pipeline
so this patch removes removes inputresources and outputresources flag
in tkn task start command and updates unit test

Signed-off-by: Shiv Verma <shverma@redhat.com>
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2023
@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2023
@tekton-robot tekton-robot merged commit b109d7f into tektoncd:main Apr 13, 2023
vinamra28 added a commit that referenced this pull request May 10, 2023
#1981 | [vinamra28] Bump versions in README to v0.30.1 | 2023/04/11-07:18
#1983 | [pratap0007] Remove PipelineResource support in clustertask | 2023/04/13-07:24
#1985 | [Zoran Regvart] Adapt for changes in TEP-0100 | 2023/04/13-07:58
#1984 | [pratap0007] Remove PipelineResource support in task | 2023/04/13-09:42
#1988 | [pratap0007] Remove PipelineResource support in pipeline | 2023/04/13-14:54
#1987 | [Basavaraju G] remove e2e pipeline resource tests | 2023/04/13-18:48
#1991 | [dependabot[bot]] Bump k8s.io/apimachinery from 0.26.3 to 0.26.4 | 2023/04/14-07:26
#1992 | [dependabot[bot]] Bump k8s.io/client-go from 0.25.8 to 0.25.9 | 2023/04/14-08:08
#1993 | [vinamra28] Use own FakeClock func instead of from library | 2023/04/14-08:44
#1993 | [dependabot[bot]] Bump github.com/jonboulle/clockwork from 0.3.0 to 0.4.0 | 2023/04/14-08:44
null | [pratap0007] Remove resource command | 2023/04/14-09:36
null | [pratap0007] Remove input and output resource in clustertask describe command | 2023/04/14-11:38
null | [dependabot[bot]] Bump k8s.io/cli-runtime from 0.25.8 to 0.25.9 | 2023/04/14-12:34
null | [Eng Zer Jun] Replace `github.com/ghodss/yaml` with `sigs.k8s.io/yaml` | 2023/04/16-13:44
null | [pratap0007] Remove all occurrence of PipelineResource and move pipeline to 0.46.0 in CI | 2023/04/17-15:06
null | [dependabot[bot]] Bump github.com/docker/cli | 2023/04/19-20:14
null | [Luiz Carvalho] Update to cosign v2 | 2023/04/19-21:38
null | [pratap0007] Remove docs related to PipelineResource | 2023/04/20-10:34
null | [dependabot[bot]] Bump k8s.io/api from 0.26.1 to 0.26.4 | 2023/04/22-04:36
null | [dependabot[bot]] Bump github.com/sigstore/sigstore from 1.6.1 to 1.6.3 | 2023/04/22-05:12
null | [dependabot[bot]] Bump github.com/docker/docker | 2023/04/22-05:46
null | [pratap0007] Remove PipelineResource in the describe command test | 2023/04/25-19:40
null | [PuneetPunamiya] Remove flags from chains payload command as not used | 2023/05/02-10:40
null | [pratap0007] Remove default value info for true flag in delete command | 2023/05/02-13:16
null | [pratap0007] Upgrade golangci version to v1.52.2 and fix lint errors | 2023/05/04-13:26
null | [pratap0007] Bump tektoncd/pipeline to 0.47.0 manually | 2023/05/05-21:34
null | [dependabot[bot]] Bump github.com/docker/cli | 2023/05/06-04:04
null | [dependabot[bot]] Bump github.com/docker/docker | 2023/05/06-04:40
null | [dependabot[bot]] Bump golang.org/x/term from 0.7.0 to 0.8.0 | 2023/05/06-12:58
null | [pratap0007] Fix tkn pr/tr delete command for keep flag | 2023/05/06-16:44
null | [dependabot[bot]] Bump github.com/tektoncd/chains | 2023/05/06-17:24
null | [Piyush Garg] Bump cosign to v2.0.2 | 2023/05/07-06:44
null | [dependabot[bot]] Bump github.com/docker/cli | 2023/05/08-16:42
null | [dependabot[bot]] Bump github.com/docker/docker | 2023/05/08-18:08
null | [dependabot[bot]] Bump github.com/tektoncd/hub from 1.12.1 to 1.13.0 | 2023/05/09-08:08

Signed-off-by: vinamra28 <jvinamra776@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants