Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hijack alibabacloud-go/cr-20160607 with v2 #2356

Closed
wants to merge 1 commit into from

Conversation

vdemeester
Copy link
Member

Changes

This should, hopefully, fix the CI.

Signed-off-by: Vincent Demeester vdemeest@redhat.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Jul 11, 2024
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from vdemeester after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 11, 2024
Trick `go-licenses` by replacing alibabacloud-go/cr-20160607 with
alibabacloud-go/cr-20160607/v2 that has a LICENSE.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@tekton-robot tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 11, 2024
@vdemeester vdemeester changed the title Ignore alibabacloud-go/cr-20160607 in license check Hijack alibabacloud-go/cr-20160607 with v2 Jul 11, 2024
@tekton-robot
Copy link
Contributor

@vdemeester: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-tekton-cli-integration-tests 7d7c193 link true /test pull-tekton-cli-integration-tests
pull-tekton-cli-build-cross-tests 7d7c193 link true /test pull-tekton-cli-build-cross-tests
pull-tekton-cli-unit-tests 7d7c193 link true /test pull-tekton-cli-unit-tests
pull-tekton-cli-build-tests 7d7c193 link true /test pull-tekton-cli-build-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vdemeester vdemeester closed this Jul 11, 2024
@vdemeester vdemeester deleted the ignore-cr-20160607 branch July 11, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesnt merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants