Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task start interactive mode #987

Merged
merged 1 commit into from
May 26, 2020
Merged

Task start interactive mode #987

merged 1 commit into from
May 26, 2020

Conversation

pradeepitm12
Copy link
Contributor

@pradeepitm12 pradeepitm12 commented May 19, 2020 •
edited

close #413

this adds interactive mode to start a task similar to pipeline
start command
this also adds some interactive start option which can be used to refactor pipeline start as well

Signed-off-by: Pradeep Kumar pradkuma@redhat.com

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

release-note

@pradeepitm12
Task start interactive mode
f797686 
close #413

this adds interactive mode to start a task similar to pipeline
start command

Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 19, 2020
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/task/start.go 91.3% 81.7% -9.6
pkg/options/start.go Do not exist 0.0%

@pradeepitm12
Copy link
Contributor Author

Thanks to @praveen4g0 for helping in the test for the PR.
we will add e2e test for interactive pipeline and task start commands, we already have WIP PR for the same #976

vdemeester
vdemeester approved these changes May 19, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/meow

@tekton-robot
Copy link
Contributor

@vdemeester: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2020
danielhelfand
danielhelfand reviewed May 20, 2020
View reviewed changes
Copy link
Member

@danielhelfand danielhelfand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tried this yet, but just wanted to throw in that this should probably have an associated e2e test. Will try and give a look today or tomorrow.

danielhelfand
danielhelfand reviewed May 26, 2020
View reviewed changes
Copy link
Member

@danielhelfand danielhelfand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2020
@tekton-robot tekton-robot merged commit d95320f into tektoncd:master May 26, 2020
@anshulvermapatel anshulvermapatel mentioned this pull request Jun 1, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielhelfand danielhelfand danielhelfand left review comments

@vdemeester vdemeester vdemeester approved these changes

@chmouel chmouel Awaiting requested review from chmouel

@sthaha sthaha Awaiting requested review from sthaha

Assignees

@danielhelfand danielhelfand

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Task start interactive mode
4 participants
@pradeepitm12 @tekton-robot @vdemeester @danielhelfand