Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release pipeline to use workspaces and results #1969

Closed
AlanGreene opened this issue Mar 5, 2021 · 7 comments
Closed

Update release pipeline to use workspaces and results #1969

AlanGreene opened this issue Mar 5, 2021 · 7 comments
Assignees
Labels
area/release Indicates an issue on release (process, tasks). kind/misc Categorizes issue or PR as a miscellaneuous one. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@AlanGreene
Copy link
Member

AlanGreene commented Mar 5, 2021

Remove use of PipelineResources, switching to Tasks with workspaces and results instead.

See tektoncd/pipeline and tektoncd/operator release pipelines for example.

It may also make sense to adopt some of the other improvements to the release pipeline such as using crane cp instead of gcloud images add-tag.

Also see https://github.com/tektoncd/triggers/pull/1000

@AlanGreene AlanGreene added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Mar 5, 2021
@AlanGreene AlanGreene self-assigned this May 20, 2021
@AlanGreene
Copy link
Member Author

Also need to update template for nightly release: https://github.com/tektoncd/plumbing/blob/2c1808d75b38d6fcaae0a37f5a9dda50545af4c8/tekton/resources/nightly-release/overlays/dashboard/template.yaml

See Pipelines / Triggers equivalent for reference.

@nikhil-thomas
Copy link
Member

/assign

@AlanGreene
Copy link
Member Author

/unassign

@AlanGreene AlanGreene added the area/release Indicates an issue on release (process, tasks). label May 26, 2021
@AlanGreene
Copy link
Member Author

Hey @nikhil-thomas, have you had a chance to look at updating the Dashboard release pipeline yet? No worries if you haven't, I was just wondering if you had run into any problems or had any questions about it.

@nikhil-thomas
Copy link
Member

hi, i haven't started on it yet. I shall definitely pick it up this week. 🧑‍💻 👍

@tekton-robot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 15, 2021
@AlanGreene
Copy link
Member Author

This is done. Nightly releases are successfully using the new pipeline and are signed with Chains 🎉

The v0.22 release (due next week) will also use this new pipeline and be signed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release Indicates an issue on release (process, tasks). kind/misc Categorizes issue or PR as a miscellaneuous one. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

3 participants