-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend Tekton Dashboard operator to create Ingress endpoint on OpenShift #228
Comments
/assign |
I'll add the following ingress. The is replaced by the ProxyIP in the Install CRD for the dashboard during the install by the operator.
|
PR in the openshift/pipeline-operator openshift/tektoncd-pipeline-operator#46 |
Issue adding the dashboard to the operator: https://github.ibm.com/swiss-cloud/swiss-planning/issues/97 |
openshift/tektoncd-pipeline-operator#46 (comment) states,
And indirectly references tektoncd/community#26, the proposal to create an 'upstream' Tekton operator in the Tekton org. @akihikokuroda we should talk about what if anything we can do in the meantime. |
So it's all in one place and on GitHub, @akihikokuroda: openshift/tektoncd-pipeline-operator#24 do we need to rebase or close this OR should we start work with https://github.com/tektoncd/operator (this is surely the upstream Tekton operator right)? I'm chasing it up because I believe with the "kabanero" project, a lot of installs are expected to be operator based including for Tekton (which is going to be a part of it) so it'd be useful to see what's going on, ensuring the latest versions of Tekton for example are being pulled in |
I've been waiting for openshift/tektoncd-pipeline-operator#23 merged. (openshift/tektoncd-pipeline-operator#23 (comment)) The https://github.com/tektoncd/operator repo is still empty and there is a pull request that copies in the contents. Once the code is copied and my pull request is merged, I will update the my pull requests for the dashboard, the dashboard ingress and the webhook. |
@mnuttall Do we still want this? We have the route for OpenShift already. If so, the OpenShift 4.x has the ingress operator. I believe we should use it instead of define the ingress manually. |
Let's close this for now. |
Further to #212 and the work to create a Tekton Dashboard operator in openshift/tektoncd-pipeline-operator#14 and https://github.com/akihikokuroda/tektoncd-pipeline-operator/tree/dashboard, this issue extends the Tekton Dashboard Operator so as to optionally create an Ingress endpoint for the dashboard.
The address of the Ingress endpoint that is created will need to be set as an environment variable within the dashboard unless there's a better way for the dashboard to determine the Ingress endpoint associated with its service.
The text was updated successfully, but these errors were encountered: