Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Create PipelineResource to a URL addressable page #1599

Closed

Conversation

AlanGreene
Copy link
Member

Replaces #1591 due to integration test job changes

Changes

Related to point 5 of #966 (move create dialogs to full page experience)

Move the Create PipelineResource form to a full page instead
of a modal. This follows the pattern we've already implemented
for Create Secret.

Update the page title.

Depends on #1589

Note: ignore whitespace for an easier review

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

Move the Create PipelineResource form to a full page instead
of a modal. This follows the pattern we've already implemented
for Create Secret.

Update the page title.
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign alangreene
You can assign the PR to them by writing /assign @alangreene in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 7, 2020
@AlanGreene
Copy link
Member Author

still looking for the old pull-tekton-dashboard-integration-tests job for some reason...

@AlanGreene AlanGreene closed this Jul 7, 2020
@AlanGreene AlanGreene deleted the createpipelineresource_page_2 branch July 7, 2020 10:51
@tekton-robot
Copy link
Contributor

@AlanGreene: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-tekton-dashboard-integration-0-13-2-tests 45808da link /test pull-tekton-dashboard-integration-tests
pull-tekton-dashboard-unit-tests 45808da link /test tekton-dashboard-unit-tests
pull-tekton-dashboard-build-tests 45808da link /test pull-tekton-dashboard-build-tests
pull-tekton-dashboard-integration-0-12-1-tests 45808da link /test pull-tekton-dashboard-integration-tests
pull-tekton-dashboard-integration-0-11-3-tests 45808da link /test pull-tekton-dashboard-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants