Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhooks table should use table skeleton rather than spinner to denote loading #62

Closed
dibbles opened this issue Jun 13, 2019 · 3 comments
Assignees
Labels

Comments

@dibbles
Copy link
Member

dibbles commented Jun 13, 2019

When the webhooks table is loading a spinner indicates the page is loading, one could reasonably argue that this should instead be rendering the page but with a carbon component table skeleton.

http://react.carbondesignsystem.com/?selectedKind=DataTableSkeleton&selectedStory=default&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybook%2Factions%2Factions-panel

@carlos-logro
Copy link
Contributor

/assign

@carlos-logro
Copy link
Contributor

/close

@tekton-robot
Copy link

@carlos-logro: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants