Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Use go-github client to replace rest request for pubsubhubbub #379

Merged
merged 1 commit into from
Dec 6, 2019
Merged

WIP: Use go-github client to replace rest request for pubsubhubbub #379

merged 1 commit into from
Dec 6, 2019

Conversation

dibbles
Copy link
Member

@dibbles dibbles commented Dec 2, 2019

Issue #362

Changes

Rather than changing to use the Hooks API via a REST request - these changes move to using the go-github library for interacting with GitHub.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

@dibbles dibbles added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 2, 2019
@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 2, 2019
@dibbles
Copy link
Member Author

dibbles commented Dec 3, 2019

/test tekton-experimental-unit-tests

@a-roberts
Copy link
Member

Just had a go with this on Docker Desktop, the hook gets made but I see

<html>
<head><title>503 Service Temporarily Unavailable</title></head>
<body>
<center><h1>503 Service Temporarily Unavailable</h1></center>
<hr><center>openresty/1.15.8.2</center>
</body>
</html

I don't see any logs from my EventListener. Redelivered and it's green and all is well

@dibbles
Copy link
Member Author

dibbles commented Dec 5, 2019

Just had a go with this on Docker Desktop, the hook gets made but I see

<html>
<head><title>503 Service Temporarily Unavailable</title></head>
<body>
<center><h1>503 Service Temporarily Unavailable</h1></center>
<hr><center>openresty/1.15.8.2</center>
</body>
</html

I don't see any logs from my EventListener. Redelivered and it's green and all is well

Give it another spin .... likely caused by eventlistener not being up and running before the webhook is created - I've added in a loop checking the eventlistener deployment for readiness .... the loop checks over a period of 30 seconds, breaking when the eventlistener is ready .... after 30 seconds the code continues to create the webhook - so you could still get the 503.

Debatable as to whether this is correct behavior or not.

a-roberts
a-roberts approved these changes Dec 5, 2019
View reviewed changes
Copy link
Member

@a-roberts a-roberts left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave this a try, all good now

/approve
Can lgtm once we're ready and we get a test pass (a new flaky unrelated to this I'm guessing)

Hmm, seeing

I1205 10:12:17.702] --- FAIL: Test_createOpenshiftRoute (0.00s)
I1205 10:12:17.703]     --- FAIL: Test_createOpenshiftRoute/OpenShift_Route (0.00s)
I1205 10:12:17.703]         webhook_test.go:945: Route mismatch (-want +got):

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-roberts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2019
@a-roberts
Copy link
Member

/test tekton-experimental-unit-tests

@a-roberts
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2019
@a-roberts a-roberts removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 6, 2019
@tekton-robot tekton-robot merged commit f873486 into tektoncd:master Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-roberts a-roberts a-roberts approved these changes

@mnuttall mnuttall Awaiting requested review from mnuttall

Assignees

@a-roberts a-roberts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dibbles @a-roberts @tekton-robot