Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pipeline/trusted-resources] Refact/clean error on return vals #888

Merged

Conversation

austinzhao-go
Copy link
Contributor

@austinzhao-go austinzhao-go commented Jun 6, 2022

Changes

Refactor the helper func getSignerFromFile to remove the unused error return val

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes docs (if user facing) - not user facing as for refactoring work
  • Commit messages follow commit message best practices
  • Commit messages includes a project tag in the subject - e.g. [OCI], [hub], [results], [task-loops]

See the contribution guide
for more details.

@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 6, 2022
@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 6, 2022
@austinzhao-go austinzhao-go marked this pull request as ready for review June 6, 2022 17:35
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 6, 2022
@austinzhao-go
Copy link
Contributor Author

austinzhao-go commented Jun 6, 2022

/hold

till #886 got merged

@austinzhao-go austinzhao-go changed the title Refact/clean error on return vals [pipeline/trusted-resources] Refact/clean error on return vals Jun 6, 2022
@austinzhao-go
Copy link
Contributor Author

/assign @Yongxuanzhang @wlynch

Copy link
Member

@wlynch wlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I think this looks good, but waiting until the base commit is submitted before approving. (alternatively if you want to cherry pick the commit that works for me too)

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 6, 2022
@austinzhao-go austinzhao-go force-pushed the refact/clean-error-on-return-vals branch from ba177f0 to 45fe01a Compare June 7, 2022 14:25
@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 7, 2022
Refactor the func to clean the unused return `error` val.
@austinzhao-go austinzhao-go force-pushed the refact/clean-error-on-return-vals branch from 45fe01a to fd60747 Compare June 7, 2022 14:28
@austinzhao-go
Copy link
Contributor Author

/unhold

as #886 was merged

Copy link
Member

@Yongxuanzhang Yongxuanzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @austinzhao-go and @wlynch !! 😄

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Yongxuanzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2022
@Yongxuanzhang
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2022
@tekton-robot tekton-robot merged commit 18cc405 into tektoncd:main Jun 7, 2022
@austinzhao-go
Copy link
Contributor Author

thanks @Yongxuanzhang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants