-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pipeline/trusted-resources] Refact/clean error on return vals #888
[pipeline/trusted-resources] Refact/clean error on return vals #888
Conversation
/hold till #886 got merged |
/assign @Yongxuanzhang @wlynch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I think this looks good, but waiting until the base commit is submitted before approving. (alternatively if you want to cherry pick the commit that works for me too)
ba177f0
to
45fe01a
Compare
Refactor the func to clean the unused return `error` val.
45fe01a
to
fd60747
Compare
/unhold as #886 was merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @austinzhao-go and @wlynch !! 😄
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Yongxuanzhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
thanks @Yongxuanzhang |
Changes
Refactor the helper func
getSignerFromFile
to remove the unusederror
return valSubmitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.