Minor bug fix in Hub CLI info command #227
Conversation
- Fixes the logic by adding a break statement
in formatting the description of resource in
Hub CLI info command
- Adds tests for wrapText function which formats
the description of resource
Signed-off-by: Puneet Punamiya <ppunamiy@redhat.com>
tekton-robot
added
the
size/S
| @@ -108,6 +108,7 @@ func breakString(desc string, width, titleLength int) string { | |||
| for i := firstLineEnd; i < descLength; i = i + spaceIndex { | |||
| if descLength < i+width { | |||
| sb.WriteString(desc[i:]) | |||
| break | |||
There was a problem hiding this comment.
Why we need this? the condition in for loop will do this
There was a problem hiding this comment.
i is incremented by adding spaceIndex but in the first case we didn't need to calculate it as it is the last line so it adds 0 in i and it goes in an infinite loop, in else we calculate spaceIndex as we need to break the line at that index.
|
/lgtm |
|
/lgtm |
|
/meow |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pratap0007 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/retest |
Fixes the logic by adding a break statement
in formatting the description of resource in
Hub CLI info command
Adds tests for wrapText function which formats
the description of resource
Signed-off-by: Puneet Punamiya ppunamiy@redhat.com
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.