Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "install" command for artifact type #747

Conversation

QuanZhang-William
Copy link
Member

Part of #691. Prior to this commit, the tkn hub install command is only supported with --type tekton. This commit adds the tkn hub install functionality for --type artifact, which fetches resources from the Artifact Hub and install to user's cluster.

Example:
tkn hub install task golang-build --from tekton-catalogs-task --version 0.2.0

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run API Unit Tests, Lint Checks, API Design, Golden Files with make api-check
  • Run UI Unit Tests, Lint Checks with make ui-check
  • Commit messages follow commit message best practices

See the contribution guide for more details.

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign sm43 after the PR has been reviewed.
You can assign the PR to them by writing /assign @sm43 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 5, 2023
Prior to this commit, the `tkn hub install` command is only supported with --type tekton. This commit adds the `tkn hub install` functionality for --type artifact, which fetches resources from the Artifact Hub and install to user's cluster.

Example:
`tkn hub install task golang-build --from tekton-catalogs-task --version 0.2.0`
@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 6, 2023
@QuanZhang-William
Copy link
Member Author

/test pull-tekton-hub-unit-tests

@tekton-robot
Copy link

@QuanZhang-William: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-tekton-hub-unit-tests 2363bf1 link true /test pull-tekton-hub-unit-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@QuanZhang-William
Copy link
Member Author

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 9, 2023
@QuanZhang-William
Copy link
Member Author

Will first merge the PR to refactor get_resources & get_resource_version in #752 and implement based on the refactored code

/close

@tekton-robot
Copy link

@QuanZhang-William: Closed this PR.

In response to this:

Will first merge the PR to refactor get_resources & get_resource_version in #752 and implement based on the refactored code

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants