Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a "type" flag to the "tkn hub" subcommands #691

Closed
2 of 9 tasks
QuanZhang-William opened this issue Oct 7, 2022 · 8 comments
Closed
2 of 9 tasks

Add a "type" flag to the "tkn hub" subcommands #691

QuanZhang-William opened this issue Oct 7, 2022 · 8 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten

Comments

@QuanZhang-William
Copy link
Member

QuanZhang-William commented Oct 7, 2022 •
edited

Feature request

The Tekton community is working on migrating from the Tekton Hub to the Artifact Hub (#667). We'd like to request a new flag type (with short flag t) to the tkn hub subcommand, indicating the type of the Hub to fetch the Tekton Catalogs from.

Use case

The Tekton Catalogs are surfaced in the Artifact Hub and the Tekton Hub. The new type flag can be set to artifact or tekton, and the corresponding hub APIs should be invoked to fetch the catalogs.

When setting to tekton, the default api-server flag should be: https://api.hub.tekton.dev.
When setting to artifact the default api-server flag should be: https://artifacthub.io.

UI Example

tkn hub install --type artifact --version 0.8

Breakdown
@QuanZhang-William QuanZhang-William added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 7, 2022
@QuanZhang-William QuanZhang-William mentioned this issue Oct 7, 2022
Open
4 tasks
@vinamra28 vinamra28 transferred this issue from tektoncd/cli Oct 14, 2022
@QuanZhang-William QuanZhang-William mentioned this issue Oct 14, 2022
Merged
4 tasks
@vinamra28
Copy link
Member

@QuanZhang-William @tektoncd/hub-collaborators listing down all the commands so that we can maintain a track of all the subcommands

  • install
  • reinstall
  • upgrade
  • downgrade
  • check-upgrade
  • get
  • info
  • search
    @QuanZhang-William if you are okay, how about we open this for contributions so that if someone wants to contribute then they can have something for contribution?

@QuanZhang-William
Copy link
Member Author

QuanZhang-William commented Oct 21, 2022 •
edited

@QuanZhang-William @tektoncd/hub-collaborators listing down all the commands so that we can maintain a track of all the subcommands

  • install
  • reinstall
  • upgrade
  • downgrade
  • check-upgrade
  • get
  • info
  • search
    @QuanZhang-William if you are okay, how about we open this for contributions so that if someone wants to contribute then they can have something for contribution?

Definitely! This is exactly what I planned to do. I will first prioritize the functionalities that unblocks TEP-0079.

This was referenced Jan 5, 2023
Closed
Merged
QuanZhang-William added a commit to QuanZhang-William/hub that referenced this issue Jan 9, 2023
@QuanZhang-William
[TEP-0079] Add Support Tier in tkn hub install command
e513e17 
Part of tektoncd#691. Prior to this change, no support tier, catalog or org information was added to the resource annotation when installing from Hub.

This commit adds `artifacthub.io/catalog`, "artifacthub.io/org" and "artifacthub.io/support-tier" labels to the resource being installed to indicate the source and support tier of the catalog. The 3 labels will only be added when installing with `--type artifact` flag.

Details can be found in https://github.com/tektoncd/community/blob/main/teps/0079-tekton-catalog-support-tiers.md#cli
@QuanZhang-William QuanZhang-William mentioned this issue Jan 9, 2023
Closed
4 tasks
@tekton-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@QuanZhang-William
Copy link
Member Author

Implementation in progress.
/remove-lifecycle stale

QuanZhang-William added a commit to QuanZhang-William/hub that referenced this issue Jan 24, 2023
@QuanZhang-William
[TEP-0079] Add Support Tier in tkn hub install command
434bb1f 
Part of tektoncd#691. Prior to this change, no support tier, catalog or org information was added to the resource annotation when installing from Hub.

This commit adds `artifacthub.io/catalog`, "artifacthub.io/org" and "artifacthub.io/support-tier" labels to the resource being installed to indicate the source and support tier of the catalog. The 3 labels will only be added when installing with `--type artifact` flag.

Details can be found in https://github.com/tektoncd/community/blob/main/teps/0079-tekton-catalog-support-tiers.md#cli
QuanZhang-William added a commit to QuanZhang-William/hub that referenced this issue Jan 24, 2023
@QuanZhang-William
[TEP-0079] Add Support Tier in tkn hub install command
e183144 
Part of tektoncd#691. Prior to this change, no support tier, catalog or org information was added to the resource annotation when installing from Hub.

This commit adds `artifacthub.io/catalog`, "artifacthub.io/org" and "artifacthub.io/support-tier" labels to the resource being installed to indicate the source and support tier of the catalog. The 3 labels will only be added when installing with `--type artifact` flag.

Details can be found in https://github.com/tektoncd/community/blob/main/teps/0079-tekton-catalog-support-tiers.md#cli
QuanZhang-William added a commit to QuanZhang-William/hub that referenced this issue Jan 24, 2023
@QuanZhang-William
[TEP-0079] Add Support Tier in tkn hub install command
10b3a62 
Part of tektoncd#691. Prior to this change, no support tier, catalog or org information was added to the resource annotation when installing from Hub.

This commit adds `artifacthub.io/catalog`, "artifacthub.io/org" and "artifacthub.io/support-tier" labels to the resource being installed to indicate the source and support tier of the catalog. The 3 labels will only be added when installing with `--type artifact` flag.

Details can be found in https://github.com/tektoncd/community/blob/main/teps/0079-tekton-catalog-support-tiers.md#cli
@QuanZhang-William QuanZhang-William mentioned this issue Jan 24, 2023
Merged
4 tasks
QuanZhang-William added a commit to QuanZhang-William/hub that referenced this issue Jan 25, 2023
@QuanZhang-William
[TEP-0079] Add Support Tier in tkn hub install command
b4d98f0 
Part of tektoncd#691. Prior to this change, no support tier, catalog or org information was added to the resource annotation when installing from Hub.

This commit adds `artifacthub.io/catalog`, "artifacthub.io/org" and "artifacthub.io/support-tier" labels to the resource being installed to indicate the source and support tier of the catalog. The 3 labels will only be added when installing with `--type artifact` flag.

Details can be found in https://github.com/tektoncd/community/blob/main/teps/0079-tekton-catalog-support-tiers.md#cli
tekton-robot pushed a commit that referenced this issue Jan 25, 2023
@QuanZhang-William @tekton-robot
[TEP-0079] Add Support Tier in tkn hub install command
42d127d 
Part of #691. Prior to this change, no support tier, catalog or org information was added to the resource annotation when installing from Hub.

This commit adds `artifacthub.io/catalog`, "artifacthub.io/org" and "artifacthub.io/support-tier" labels to the resource being installed to indicate the source and support tier of the catalog. The 3 labels will only be added when installing with `--type artifact` flag.

Details can be found in https://github.com/tektoncd/community/blob/main/teps/0079-tekton-catalog-support-tiers.md#cli
@tekton-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten
Projects
Tekton Community Roadmap
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@QuanZhang-William @vinamra28 @tekton-robot