Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEP-0079] Refactor get_resource and get_resource_version for multiple hub support #752

Merged
merged 1 commit into from
Jan 19, 2023
Merged

[TEP-0079] Refactor get_resource and get_resource_version for multiple hub support #752

merged 1 commit into from
Jan 19, 2023

Conversation

QuanZhang-William
Copy link
Member

@QuanZhang-William QuanZhang-William commented Jan 9, 2023 •
edited
Loading

Part of #691. No functionality change in this PR. Prior to this change, the Hub CLI supports only 1 type of Hub (Tekton Hub).

This commit

  1. refactors the ResourceResult and ResourceVersionResult to interfaces;
  2. creates THResourceResult and THResourceVersionResult structs implementing the interfaces, keeping original support for Tekton Hub;
  3. creates AHResourceResult and AHResourceVersionResult for Artifact Hub, implementations will be added in later PRs.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run API Unit Tests, Lint Checks, API Design, Golden Files with make api-check
  • Run UI Unit Tests, Lint Checks with make ui-check
  • Commit messages follow commit message best practices

See the contribution guide for more details.

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 9, 2023
This was referenced Jan 9, 2023
Closed
Merged
@QuanZhang-William
Copy link
Member Author

QuanZhang-William commented Jan 9, 2023 •
edited
Loading

Part of: #691

@QuanZhang-William
Copy link
Member Author

/cc @vinamra28 @PuneetPunamiya @pratap0007. Could you please help take a look 😄

PuneetPunamiya
PuneetPunamiya reviewed Jan 17, 2023
View reviewed changes
Copy link
Member

@PuneetPunamiya PuneetPunamiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall patch looks good, but should we have one command in the working stage with the artifact hub api

@QuanZhang-William
Copy link
Member Author

The overall patch looks good, but should we have one command in the working stage with the artifact hub api

@PuneetPunamiya. Just discussed with @vinamra28, the details for implementation is in this PR (which is based on this one). The other PR is pretty big so that's why I split it to 2 ones so that it is easier to get quick feedback and the review for the other one is easier.

Can we merge this PR and I will rebase #757?

@pratap0007
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2023
vinamra28
vinamra28 reviewed Jan 18, 2023
View reviewed changes
Copy link
Member

@vinamra28 vinamra28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall PR looks good to me
/lgtm

@QuanZhang-William
Refactor get_resource and get_resource_version for multiple hub support
60a677a 
No functionality change in this PR. Prior to this change, the Hub CLI supports only 1 type of Hub (Tekton Hub).

This commit 1) refactors the `ResourceResult` and `ResourceVersionResult` to interfaces;
2) creates THResourceResult and THResourceVersionResult structs implementing the interfaces, keeping original support for Tekton Hub;
3) creates AHResourceResult and AHResourceVersionResult for Artifact Hub, implementations will be added in later PRs.
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2023
@PuneetPunamiya
Copy link
Member

Thanks for the patch 🤙🏻
/approve
/meow

@tekton-robot
Copy link

@PuneetPunamiya: cat image

In response to this:

Thanks for the patch 🤙🏻
/approve
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PuneetPunamiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2023
@vinamra28
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2023
@tekton-robot tekton-robot merged commit b20c25d into tektoncd:main Jan 19, 2023
@QuanZhang-William QuanZhang-William changed the title Refactor get_resource and get_resource_version for multiple hub support [TEP-0079] Refactor get_resource and get_resource_version for multiple hub support Feb 17, 2023
@QuanZhang-William QuanZhang-William mentioned this pull request Jun 12, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinamra28 vinamra28 vinamra28 left review comments

@PuneetPunamiya PuneetPunamiya PuneetPunamiya left review comments

@sthaha sthaha Awaiting requested review from sthaha

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@vinamra28 vinamra28

@pratap0007 pratap0007

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@QuanZhang-William @pratap0007 @PuneetPunamiya @tekton-robot @vinamra28