Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Tekton Prow jobs invoke Tekton Pipelines #538

Closed
bobcatfish opened this issue Feb 21, 2019 · 5 comments
Closed

Make Tekton Prow jobs invoke Tekton Pipelines #538

bobcatfish opened this issue Feb 21, 2019 · 5 comments
Assignees
Labels
design This task is about creating and discussing a design meaty-juicy-coding-work This task is mostly about implementation!!! And docs and tests of course but that's a given

Comments

@bobcatfish
Copy link
Collaborator

Expected Behavior

The CI/CD used by Tekton Pipelines (triggered via prow jobs) should be able to invoke Pipelines.

In the long run we want Pipeline support in Prow (#537), but in the meantime, we can make the existing Prow jobs:

  • Deploy Tekton Pipelines (to the Prow cluster itself? not sure, will need input)
  • Create a PipelineRun from a template

For this issue, we can create just a "Hello world" type PipelineRun, to prove it works.

Actual Behavior

The CI/CD used by Tekton Pipelines (triggered via prow jobs) invokes scripts only.

Additional Info

This is the short term solution, the long term solution is #537. If we can go straight to that, even better!

@bobcatfish bobcatfish added design This task is about creating and discussing a design meaty-juicy-coding-work This task is mostly about implementation!!! And docs and tests of course but that's a given labels Feb 21, 2019
@bobcatfish bobcatfish added okr This is for some internal Google project tracking and removed okr This is for some internal Google project tracking labels Feb 21, 2019
@abayer
Copy link
Contributor

abayer commented Feb 21, 2019

Is @rawlingsj's Prow work close enough to ready to be feasible here in the near term?

@rawlingsj
Copy link
Contributor

We have a pipeline controller that seems to be working great https://github.com/jenkins-x/test-infra/blob/238d673/prow/cmd/pipeline/controller.go - main issue ATM it's slightly tied to Jenkins X as we have it optionally calling out to the 'pipelinerunner' service. I did want to take what I've done and apply a non Jenkins X related PR to the test-infra repo but not been able to yet unfortunately.

@dlorenc
Copy link
Contributor

dlorenc commented Apr 23, 2019

I don't think this is still relevant. Prow can call Tekton tasks already. Closing for now.

@dlorenc dlorenc closed this as completed Apr 23, 2019
@bobcatfish
Copy link
Collaborator Author

I'm gonna assign this to @rawlingsj for posterity :D thanks for this @rawlingsj !!! 🎉 ❤️

@bobcatfish bobcatfish assigned bobcatfish and rawlingsj and unassigned bobcatfish May 14, 2019
@bobcatfish
Copy link
Collaborator Author

#537

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design This task is about creating and discussing a design meaty-juicy-coding-work This task is mostly about implementation!!! And docs and tests of course but that's a given
Projects
None yet
Development

No branches or pull requests

4 participants