Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow pipeline runs whose task/custom runs have been deleted still timeout #7556

Closed
gabemontero opened this issue Jan 10, 2024 · 0 comments · Fixed by #7557
Closed

allow pipeline runs whose task/custom runs have been deleted still timeout #7556

gabemontero opened this issue Jan 10, 2024 · 0 comments · Fixed by #7557
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@gabemontero
Copy link
Contributor

Expected Behavior

Back with PR 5134 Tekton started using the cancel function for cleaning up
underlying TaskRuns of PipelineRuns that are timing out, though separate
timeout functions were used (presumably in case the timeout behavior needed to be
tweaked from the cancel behavior later on). Then, in PR 5288, improvements to the baseline cancel function were made to still complete cancel processing of a
PipelineRun if the underlying TaskRuns were deleted. Presumably, the same would occur with timeouts, which use cancel under the covers.

Actual Behavior

PipelineRuns that timeout, but whose underlying TaskRuns have been deleted, get stuck with the success condition being "unknown" and the reason code `PipelineRunCouldntTimeOut

Steps to Reproduce the Problem

  1. create a pipelinerun with a timeout, and then set it up so it does not complete in that timeout (add a long sleep for example)
  2. delete its taskrun(s)/customrun(s) while it is sleeping
  3. see what happens when the timeout starts

Additional Info

  • Kubernetes version:

various versions

  • Tekton Pipeline version:

0.53.x and forward, minimally

I'll be submitting a PR that strives to address this momentarily

@vdemeester @afrittoli @abayer FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant